Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processed files in mounted folders with incorrect extension being renamed when opened externally #1975

Closed
lfcnassif opened this issue Nov 11, 2023 · 2 comments
Closed

Processed files in mounted folders with incorrect extension being renamed when opened externally #1975

lfcnassif opened this issue Nov 11, 2023 · 2 comments
Assignees
@lfcnassif
Labels
bug

Comments

@lfcnassif
Copy link
Member

Just detected this while testing #1896. Beyond changing the evidence, the internal viewer stops working because it tries to find the original file with the incorrect extension after it was renamed to the right one.
@lfcnassif lfcnassif added the bug label Nov 11, 2023
@lfcnassif lfcnassif self-assigned this Nov 11, 2023
@lfcnassif
Copy link
Member Author

lfcnassif commented Nov 11, 2023 •
edited

So, Item.getTempFile() returns the original File if it exists. Should we change it to always copy the original File to a temp File (should have a performance impact) or update its documentation to state it may return the original File if it exists and change depending code accordingly?

@lfcnassif
Copy link
Member Author

Just pushed the second approach

lfcnassif added a commit that referenced this issue Apr 3, 2024
@lfcnassif
fix #1975: create temp File before opening File with bad ext externally
2c1b876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfcnassif lfcnassif

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lfcnassif