Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From a selected media file, go to related conversations / p2p histories #49

Closed
lfcnassif opened this issue Mar 21, 2020 · 12 comments · Fixed by #628
Closed

From a selected media file, go to related conversations / p2p histories #49

lfcnassif opened this issue Mar 21, 2020 · 12 comments · Fixed by #628
Assignees

Comments

@lfcnassif
Copy link
Member

Similar to "go to parent folder", it would be useful to find chats where a specific media file was sent or received and automatically scroll down to the media transfer point into the chat.

@lfcnassif
Copy link
Member Author

lfcnassif commented May 26, 2021

For those interested, while this is not implemented, it is possible to search for:
linkedItems:(mediaHash)

To find the chats where the media was linked to. If WhatsApp, mediaHash must be the sha-256 of the file, for other apps, md5. Unfortunately, for now the user must scroll down manually to find the media position into the chat.

@lfcnassif
Copy link
Member Author

In the past I thought about a dialog listing multiple chats pointing to the same media, but this could be implemented like SimilarImageSearchFilter.

And when some chat is selected, a similar approach used by "Go to parent chat position" from individual messages could be used to scroll down to media position in chat.

@lfcnassif
Copy link
Member Author

Or maybe a new tab in the lower-central panel to show chats referring to the media selected in the main table. In the past I have already thought about converting this panel to a generalized "Related Items" panel, with 1 tab for duplicates, 1 single tree tab for subitems/parent items, and other 1 or 2 tabs for items with incoming/outgoing references.

The advantage is the user won't need to leave current filter state to view the related items.

Eventually, other features like Similar(Images|Docs|Faces)Search could be converted to this new approach, not sure if better, would still need to show and sort by score in the new "similar items" tab.

@lfcnassif
Copy link
Member Author

Opinions? We can open a new ticket to track last suggestion if someone thinks it's a good idea...

@wladimirleite
Copy link
Member

Or maybe a new tab in the lower-central panel to show chats referring to the media selected in the main table. In the past I have already thought about converting this panel to a generalized "Related Items" panel, with 1 tab for duplicates, 1 single tree tab for subitems/parent items, and other 1 or 2 tabs for items with incoming/outgoing references.

The advantage is the user won't need to leave current filter state to view the related items.

Eventually, other features like Similar(Images|Docs|Faces)Search could be converted to this new approach, not sure if better, would still need to show and sort by score in the new "similar items" tab.

I like this idea. It is similar to what I discussed with other users here, who want to find chats in which a image/video was sent/received.
As there could be many of them, showing in a list seems better than the direct navigation ("go to chat").
Adding another tab in the central panel is a possible solution, but as there are already quite a few, maybe reorganizing them as you said, possibly merging some of them in a tree style, with more than one root would be good idea.

About the similar items search, at least from images and faces, I think the gallery view is crucial, so the current interface (placing hits in the item list) seems better.

@lfcnassif
Copy link
Member Author

About the similar items search, at least from images and faces, I think the gallery view is crucial, so the current interface (placing hits in the item list) seems better.

good point, I totally agree.

@lfcnassif
Copy link
Member Author

lfcnassif commented May 27, 2021

For this issue, printing the media hash or name in chats is an easy workaround, although not the ideal solution. What do you think @fmpfeifer?

@lfcnassif
Copy link
Member Author

If user searches for the media hash/name directly on search bar, some false positives could be returned (or chats with carved linked items could be missed if 'name' is used), but scroll to chat position would work.

@lfcnassif
Copy link
Member Author

if found item name is printed (carved-xxx) instead of original DB entry name, chats with carved linked items would be returned too. Printing sha-256 for whatsapp chats would waste too much space...

@lfcnassif
Copy link
Member Author

lfcnassif commented May 27, 2021

We could also print md5 for whatsapp just retrieving it from query results instead of using original sha-256 of medias stored in DB.

@lfcnassif lfcnassif self-assigned this Jun 24, 2021
@lfcnassif
Copy link
Member Author

lfcnassif commented Jun 24, 2021

I will try to implement the new tab ideia...

Hopefully in the next days the v3.18.7 will be released, some important fixes were done. I was thinking about being very conservative and including just fixes or simple/very small enhancements. This feature is kind independent, except for some changes needed in chat parsers to allow the scroll to media position to work. What other devs think, this should be included or not?

@lfcnassif
Copy link
Member Author

lfcnassif commented Jun 24, 2021

Chat parsers didn't need to be changed as there was already an element name=hash used to select/unselect medias :).
This is also working to find P2P histories where a media was shared, except the scrolling. I will change P2P parsers to put a name=hash in each table div, so scroll should work too.

lfcnassif added a commit that referenced this issue Jun 25, 2021
lfcnassif added a commit that referenced this issue Jun 25, 2021
@lfcnassif lfcnassif changed the title From a selected media file, go to related conversation(s) From a selected media file, go to related conversations / p2p histories Jun 25, 2021
lfcnassif added a commit that referenced this issue Jun 25, 2021
Conflicts:
	iped-app/resources/localization/iped-desktop-messages.properties
	iped-app/resources/localization/iped-desktop-messages_pt_BR.properties
lfcnassif added a commit that referenced this issue Jun 25, 2021
Conflicts:
	iped-app/resources/localization/iped-desktop-messages.properties
	iped-app/resources/localization/iped-desktop-messages_pt_BR.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants