-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1533 abort processing if OpenSearch/MinIO retries are exhausted #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If retries is set to -1 retry indefinitely;
Thank you @hauck-jvsh! |
…ready have been indexed;
…if_MinIO-Opensearch_fails
…ommand line, env vars or system properties. This behavior is similar to the one used in the MinIOTask
hauck-jvsh
force-pushed
the
#1533_abort_if_MinIO-Opensearch_fails
branch
from
May 2, 2023 16:28
f9a8635
to
6f5bb7f
Compare
…if_MinIO-Opensearch_fails
…if_MinIO-Opensearch_fails
Hi @hauck-jvsh, is this being used in our production environment? |
Hi, no, in our production environment only the latest release (4.1.2) was used. As the evidences being processed were real we think it was better to use only released versions. |
lfcnassif
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request abort processing if OpenSearch/MinIO retries are exhausted, and changes the MinIO task to use the the evidenceUUID as the bucket name.
Closes #1533