Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram channels support for Android databases (#2134) #2138

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

wladimirleite
Copy link
Member

Closes #2134.

@lfcnassif
Copy link
Member

Thanks @wladimirleite!

@lfcnassif
Copy link
Member

I'm waiting for a regression test on 150 Telegram DBs to finish, so we can merge this.

@lfcnassif
Copy link
Member

Master extracted ~2.4K more messages (from ~2.3M), but from iOS DBs, not from Android DBs. I had a "disk full" issue while processing and resumed it, so possibly that difference is related to resuming. I'll run again the failed processing with master to make sure everything is fine, looking at the code seems iOS processing wasn't changed.

@wladimirleite
Copy link
Member Author

There were some changes in the common part of the code, also used when parsing Telegram iOS databases, but in theory it shouldn't affect the number of messages. Obviously it possible that some regression was introduced. Let me know about the results when the tests finish.

Copy link
Member

@lfcnassif lfcnassif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test finished, everything looks fine, thank you @wladimirleite!

@lfcnassif lfcnassif merged commit 49e28af into master Mar 28, 2024
2 checks passed
@lfcnassif lfcnassif deleted the #2134_TelegramChannelsAndroid branch March 28, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Telegram Channels support on Android
2 participants