Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors when loading migration file fails #32

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

jesstelford
Copy link
Contributor

@jesstelford jesstelford commented Oct 9, 2018

For example, I did something silly and used await at the top level:

await Promise.resolve(true);

module.exports = {
  up(db) { /* .. */ },
  up(db) { /* .. */ },
};

This change catches the error and reports it as a failed migration.

Checklist
  • npm test passes and has 100% coverage

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88f7430 on jesstelford:patch-2 into f729842 on seppevs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88f7430 on jesstelford:patch-2 into f729842 on seppevs:master.

@seppevs seppevs merged commit 9a4b21c into seppevs:master Oct 10, 2018
@seppevs
Copy link
Owner

seppevs commented Oct 10, 2018

Landed in v4.1.1 🎉
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants