Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for configuration related errors #34

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

katsanva
Copy link
Contributor

@katsanva katsanva commented Oct 19, 2018

Fix for

(node:14343) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'forEach' of undefined
    at printMigrated (~/node_modules/migrate-mongo/bin/migrate-mongo.js:10:12)
    at migrateMongo.database.connect.then.then.catch.err (~/node_modules/migrate-mongo/bin/migrate-mongo.js:74:9)

That was caused by errors like

Error: config file does not exist
MongoError: collection name must be a String
etc.

Checklist
  • npm test passes and has 100% coverage
  • README.md is updated

Fix for 
```
(node:14343) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'forEach' of undefined
    at printMigrated (~/node_modules/migrate-mongo/bin/migrate-mongo.js:10:12)
    at migrateMongo.database.connect.then.then.catch.err (~/node_modules/migrate-mongo/bin/migrate-mongo.js:74:9)
```

That was caused by errors like
> Error: config file does not exist
> MongoError: collection name must be a String
etc.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0dcea8c on katsanva:patch-1 into 0d06a25 on seppevs:master.

@seppevs seppevs merged commit e9de061 into seppevs:master Oct 22, 2018
@seppevs
Copy link
Owner

seppevs commented Oct 22, 2018

Your patch has landed in v4.1.2 🎉 Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants