Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failedFiles vs FailedFiles #65

Closed
keithjpaulson opened this issue Oct 19, 2015 · 4 comments
Closed

failedFiles vs FailedFiles #65

keithjpaulson opened this issue Oct 19, 2015 · 4 comments
Assignees

Comments

@keithjpaulson
Copy link

I'm seeing:

/opt/ruby/2.1.2/lib/ruby/gems/2.1.0/gems/aptly_cli-0.1.6/lib/aptly_repo.rb:123:in 'repo_upload': undefined method 'empty?' for nil:NilClass (NoMethodError)

in aptly_repo.rb; code references json_response["failedFiles"], but I see FailedFiles if I run the API manually.

@sepulworld
Copy link
Owner

Thank you @keithjpaulson for the report. I will take a look and write a fix and test for this bug

@sepulworld
Copy link
Owner

@keithjpaulson I merged the fixes and updated aptly_cli gem to 0.1.8

https://rubygems.org/gems/aptly_cli

Please update and validate fix for me

@sepulworld sepulworld self-assigned this Oct 19, 2015
@keithjpaulson
Copy link
Author

I got the 0.1.8 version on update, and it is performing repo-upload without issue (though json is printed, unsure if that is intended...but I don't mind seeing feedback)

$ aptly-cli repo_upload --dir test1 --name ssr-precise -trace
{"FailedFiles"=>[], "Report"=>{"Warnings"=>[], "Added"=>["mariadb-common_5.5.32+maria-1~precise_all added"], "Removed"=>[]}}

@sepulworld
Copy link
Owner

Thanks for confirming it works. Yeah, it just returns the JSON response the is received from Aptly API.

I opened up a new issue to improve CLI response output. #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants