Convert option.snapshots to Hash before passing to publish_update #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sepulworld Any idea on when you can get around to this? |
|
I can look at this soon sorry I missed the notification that there was a pull request |
|
That would be great, thanks. |
|
Let me do some testing on it this week. At the latest Ill have a response and/or merge of this patch this weekend. |
|
Thank you for catching this bug. I was able to replicate it on the test/Dockerfile environment. Before I merge can you add c.example 'Update snapshot',
'aptly-cli publish_update --snapshots testrepo_single_snap_to_pub,main --prefix . --distribution=precise --gpg_skip'right after line 322 in bin/aptly-cli |
sepulworld
reviewed
Sep 16, 2016
| @@ -322,7 +322,7 @@ command :publish_update do |c| | |||
| c.example 'description', 'aptly-cli publish_update --forceoverwrite --distribution precise' | |||
There was a problem hiding this comment.
Add example of a 'snapshot update' here perhaps.
c.example 'update snapshot',
'aptly-cli publish_update --snapshots testrepo_single_snap_to_pub,main --prefix . --distribution=precise --gpg_skip'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I can't seem to get
publish_updateto work. With this patch applied I can run it like this:aptly-cli publish_update --snapshots jessie-snapshot,main --prefix . --distribution=jessie. I'm pretty sure I'm just too stupid to guess the correct syntax to make it work without the patch, but here is a pull request just in case. If I'm just not using it right, please tell me.