Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method selection over CLI does not work properly #59

Closed
eldariont opened this issue Feb 11, 2021 · 1 comment · Fixed by #64
Closed

Method selection over CLI does not work properly #59

eldariont opened this issue Feb 11, 2021 · 1 comment · Fixed by #64
Assignees
Labels
bug Something isn't working

Comments

@eldariont
Copy link
Collaborator

Hi,

for me, the selection of specific junction detection methods (probably the same for clustering methods) via the CLI does not work properly. As introduced with #45, the set of methods to use can be specified via the -m option. But when I add seqan3::debug_stream << args.methods << '\n'; after the argument parsing:

> build/bin/detect_breakends simulated.minimap2.hg19.coordsorted_cutoff.sam insertion_file_out.fasta -m1
[1,2,3,4,1]
...
The read pair method is not yet implemented.
The read depth method is not yet implemented.
...

Apparently, the parser just appends values to the already initialized std::vector<uint8_t> methods{1, 2, 3, 4}; and executes all methods even though -m1 was called.

Best
David

@eldariont eldariont added the bug Something isn't working label Feb 11, 2021
@Irallia Irallia reopened this Feb 11, 2021
@Irallia
Copy link
Collaborator

Irallia commented Feb 11, 2021

I have already noticed the problem and have a solution lying around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants