Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgzf threads not configurable #304

Closed
eseiler opened this issue Nov 24, 2020 · 4 comments
Closed

bgzf threads not configurable #304

eseiler opened this issue Nov 24, 2020 · 4 comments

Comments

@eseiler
Copy link
Member

eseiler commented Nov 24, 2020

Platform

Description

https://github.com/seqan/seqan3/blob/d37ba83a333992a551ec835097e564d8b9a00604/include/seqan3/contrib/stream/bgzf_stream_util.hpp#L41

We always use all threads when using bgzf stuff.
In conjunction with seqan/seqan3#2278, it makes the nightly situation worse.

How to repeat the problem

Run any executable making use of bgzf

Expected behaviour

I want to be able to not use all threads.
I think we had a similar problem in seqan2 and solved it via some definition?

Actual behaviour

Uses all threads.

@h-2
Copy link
Member

h-2 commented Jan 26, 2021

Workaround: You should be able to just set the global variable to a different value to change the behaviour globally.
Fix: I have changed the code in the bgzf handling to expose the thread number as a constructor argument, but this would need to be tied into the configuration system of I/O which is still undecided (AFAIK).

edit: I fixed it locally I meant. Hope to have time soon to make a PR.

@eseiler
Copy link
Member Author

eseiler commented Apr 6, 2021

This was addressed in seqan/seqan3#2493 which added an example on how to configure the threads.

See here for some thoughts: seqan/seqan3#2455 (comment)
We do not want a global variable, but it's also not easy to elegantly include this setting.

@marehr
Copy link
Member

marehr commented Apr 12, 2021

For now, it is documented, but we want to have a finer control per file-instance. I'll move this issue to product_backlog, to remind us in the design.

@marehr marehr transferred this issue from seqan/seqan3 Apr 12, 2021
@eseiler
Copy link
Member Author

eseiler commented Oct 20, 2022

seqan/seqan3#2752

@eseiler eseiler closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants