Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fetch googletest on demand #47

Closed
3 of 9 tasks
joergi-w opened this issue Apr 3, 2020 · 1 comment · Fixed by seqan/app-template#15
Closed
3 of 9 tasks

cmake: fetch googletest on demand #47

joergi-w opened this issue Apr 3, 2020 · 1 comment · Fixed by seqan/app-template#15
Assignees
@marehr @joergi-w
Labels
ready to tackle This story was discussed and can be immidietly tackled
Milestone
Sprint 3

Comments

@joergi-w
Copy link
Member

joergi-w commented Apr 3, 2020 •
edited

Description

As application user I want to download the googletest on first use so I can run the app with a smaller download.

Like in SeqAn3 library we want to download and build the gtest library when the tests are built for the first time.

Acceptance Criteria

  • Gtest is not anymore a git submodule of app_template.
  • Gtest is made available during the first test build.
  • Gtest is not required for running the app.

Tasks

Moved from issue #3

  • Change cmake to fetch and build gtest within configuration step using FETCH_CONTENT

Edit by Jörg: No, we do not use FETCH_CONTENT, because it contradicts with the execution during build time. FETCH_CONTENT would download in the CMake configuration step!

Definition of Done

  • Implementation and design approved
  • Unit tests pass
  • CLI tests pass (if already imlpemented)
  • Test suite compiles in less than 30 seconds (on travis)
  • Changelog entry added
@joergi-w joergi-w mentioned this issue Apr 3, 2020
Closed
13 tasks
@rrahn rrahn added the ready to tackle This story was discussed and can be immidietly tackled label Apr 3, 2020
@marehr marehr self-assigned this Apr 9, 2020
@marehr
Copy link
Member

marehr commented Apr 9, 2020

Mine, because I want this in seqan3 to.

@rrahn rrahn added this to the Sprint 2 milestone Apr 13, 2020
@marehr marehr changed the title As application user I want to download the googletest on first use so I can run the app with a smaller download. cmake: fetch googletest on demand Apr 20, 2020
@rrahn rrahn modified the milestones: Sprint 2, Sprint 3 Apr 27, 2020
@joergi-w joergi-w mentioned this issue May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marehr marehr

@joergi-w joergi-w

Labels
ready to tackle This story was discussed and can be immidietly tackled
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging a pull request may close this issue.

Download Googletest on demand during 'make test' routine. seqan/app-template
3 participants
@marehr @rrahn @joergi-w