Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimiser View works with reverse k-mers #84

Closed
11 tasks done
MitraDarja opened this issue May 12, 2020 · 0 comments
Closed
11 tasks done

Minimiser View works with reverse k-mers #84

MitraDarja opened this issue May 12, 2020 · 0 comments
Assignees
@MitraDarja
Labels
ready to tackle This story was discussed and can be immidietly tackled

Comments

@MitraDarja
Copy link

MitraDarja commented May 12, 2020 •
edited

Description

I want a minimiser_view, which accept a second range, so that the minimiser is the minimal value in a window between two ranges. I also want a minimiser_hash_view, which considers the reverese complement when calculation.

Acceptance Criteria

  • minimiser_view gets a second range, which is defaulted to empty_type
  • reverese complement to minimiser_hash_view is default, not using reverse_complement has to be specified by an variable (like reverese = false)

Tasks

  • Add second range to minimiser_view
  • Add reverese complement to minimiser_hash_view as default
  • write a tutorial showing a use case for the minimizer view

Definition of Done

  • Implementation and design approved
  • Unit tests pass
  • Test coverage = 100%
  • API documentation added
  • Tutorial/teaching material added
  • Test suite compiles in less than 30 seconds (on travis)
@MitraDarja MitraDarja added the ready to tackle This story was discussed and can be immidietly tackled label May 12, 2020
@MitraDarja MitraDarja self-assigned this May 12, 2020
@Irallia Irallia mentioned this issue Mar 21, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitraDarja MitraDarja

Labels
ready to tackle This story was discussed and can be immidietly tackled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MitraDarja