Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Structure IO] Remove file column interface #1397

Closed
9 tasks done
joergi-w opened this issue Dec 4, 2019 · 0 comments · Fixed by #1398
Closed
9 tasks done

[Structure IO] Remove file column interface #1397

joergi-w opened this issue Dec 4, 2019 · 0 comments · Fixed by #1398
Assignees
Projects

Comments

@joergi-w
Copy link
Member

joergi-w commented Dec 4, 2019

Level 1 - Easy

We expose a broken file column interface for our files. Read the documentation of structure_file_input to get to know the interface.

  • Remove all tests for the column interface (usually have column in their test name)
  • Remove the Tuple interface from the sequence_file_input object (all get functions)
  • Remove the file_as_tuple_type columns_buffer;
  • Remove the member function read_columns
  • Remove the std-overloads for the tuple like interface
  • Remove all Field column types and tuple type (see group of types in the beginning)
  • Remove the column based reading from the documentation of structure_file_input. Check if it is mentioned anywhere else in the documentation!
  • Remove all container_container concepts from the structure_file_input_traits and remove the corresponding documentation
  • Remove the container_container types from structure_file_input_default_traits_rna/aa
@joergi-w joergi-w created this issue from a note in Module: I/O (Sprint todos) Dec 4, 2019
@joergi-w joergi-w moved this from Sprint todos to In progress in Module: I/O Dec 4, 2019
@joergi-w joergi-w self-assigned this Dec 4, 2019
Module: I/O automation moved this from In progress to 🍻 Done Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Module: I/O
  
🍻 Done
Development

Successfully merging a pull request may close this issue.

1 participant