Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reuse Publisher/Subscriber if message type is different #13

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Don't reuse Publisher/Subscriber if message type is different #13

merged 1 commit into from
Sep 2, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Sep 1, 2020

No description provided.

@at-wat at-wat self-assigned this Sep 1, 2020
@f-fl0
Copy link

f-fl0 commented Sep 1, 2020

@at-wat we don't need to wait for the robot software release to open and merge this PR, right?

@at-wat at-wat marked this pull request as ready for review September 1, 2020 09:50
@at-wat at-wat requested review from f-fl0 and t-asaka September 1, 2020 11:02
@at-wat
Copy link
Member Author

at-wat commented Sep 1, 2020

@t-asaka @f-fl0 please take a look.

f-fl0
f-fl0 approved these changes Sep 1, 2020
View reviewed changes
Copy link

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit c48e215 into master Sep 2, 2020
@at-wat at-wat deleted the dont-reuse-subscriber-for-different-msg branch September 2, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-asaka t-asaka t-asaka approved these changes

@f-fl0 f-fl0 f-fl0 approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@at-wat @f-fl0 @t-asaka