Fix non-directory source path handling #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 76.25% 79.47% +3.22%
==========================================
Files 4 4
Lines 240 268 +28
==========================================
+ Hits 183 213 +30
+ Misses 32 31 -1
+ Partials 25 24 -1
Continue to review full report at Codecov.
|
at-wat
force-pushed
the
fix-non-dir-source
branch
from
8a865a9
to
441bd43
Compare
|
@kt3k @kamatama41 please take a look |
kt3k
reviewed
Oct 1, 2020
Comment on lines
+381
to
+389
| if name == "." { | ||
| // Single file was specified | ||
| c <- &fileInfo{ | ||
| name: filepath.Base(*object.Key), | ||
| path: filepath.Dir(*object.Key), | ||
| size: *object.Size, | ||
| lastModified: *object.LastModified, | ||
| singleFile: true, | ||
| } |
kt3k
reviewed
Oct 1, 2020
s3sync_test.go
Outdated
| if err := New(getSession()).Sync("s3://example-bucket/README.md", filepath.Join(temp, "foo")+"/"); err != nil { | ||
| t.Fatal("Sync should be successful", err) | ||
| } | ||
| // Download to ./foo/README.md |
There was a problem hiding this comment.
Maybe this should be Download to ./test.md?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69