Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect future timestamp as error #129

Merged
merged 4 commits into from Jan 4, 2023
Merged

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jan 4, 2023

Restart the node if continuously errored

@at-wat at-wat self-assigned this Jan 4, 2023
@sqbot

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 90.39% // Head: 90.39% // No change to project coverage 👍

Coverage data is based on head (a2b8695) compared to base (d149c1b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          15       15           
  Lines         281      281           
=======================================
  Hits          254      254           
  Misses         27       27           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sqbot
Copy link
Member

sqbot commented Jan 4, 2023

[119] PASSED on melodic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 43 tests, 0 errors, 0 failures, 0 skipped

[119] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 43 tests, 0 errors, 0 failures, 0 skipped

@at-wat at-wat requested a review from Taka-Kazu January 4, 2023 08:04
Copy link

@Taka-Kazu Taka-Kazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit 6e7b27a into master Jan 4, 2023
@at-wat at-wat deleted the detect-future-timestamp-as-error branch January 4, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants