Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot on reset error only if requested reset #135

Merged
merged 1 commit into from Aug 31, 2023

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Aug 31, 2023

Due to the II command during measurement for sensor time estimation, the data stream may be split by II response.
Split data stream may randomly start with RS and be detected as a reset failure.

This commit avoids reboot on reset failure when reset is not requested.

Due to the II command during measurement, the data stream may be split by II response.
Split data stream may randomly start with RS and be detected as a reset failure.
This commit avoids reboot on reset failure when reset is not requested.
@at-wat at-wat self-assigned this Aug 31, 2023
@sqbot
Copy link
Member

sqbot commented Aug 31, 2023

[133] PASSED on noetic

All tests passed
build/test_results/urg_stamped/gtest-test_decode.xml: 4 tests
build/test_results/urg_stamped/gtest-test_device_time_origin.xml: 6 tests
build/test_results/urg_stamped/gtest-test_first_order_filter.xml: 6 tests
build/test_results/urg_stamped/gtest-test_param.xml: 12 tests
build/test_results/urg_stamped/gtest-test_timestamp_moving_average.xml: 6 tests
build/test_results/urg_stamped/gtest-test_timestamp_outlier_remover.xml: 4 tests
build/test_results/urg_stamped/gtest-test_walltime.xml: 4 tests
build/test_results/urg_stamped/roslint-urg_stamped.xml: 1 tests
Summary: 43 tests, 0 errors, 0 failures, 0 skipped

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (438d953) 86.56% compared to head (d41bea5) 86.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files          15       15           
  Lines         201      201           
=======================================
  Hits          174      174           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat requested a review from Taka-Kazu August 31, 2023 02:02
@at-wat at-wat merged commit e00c676 into master Aug 31, 2023
5 checks passed
@at-wat at-wat deleted the reboot-on-reset-error-only-if-requested branch August 31, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants