Can't click "show details" on sssh connection error

[Jason-Morcos]

I get the error "The SSH Tunnel has unexpectedly closed.". When I click Show Detail, the popup disappears without telling me why.

[Jason-Morcos]

@gboudreau I'm not sure what's causing this one. I too had the show details button working a few commits ago. Perhaps sandboxing interrupted this too? Or perhaps it was unrelated

[Jason-Morcos]

Perhaps it was related to this fix?

437a0bd

[gboudreau]

I can take a look, if you are not already on it..?
*edit: No, the problem isn't 437a0bd; I tried reversing only that commit, and the problem is still there. I'll just use git bisect to find the culprit.
*edit 2: seems to be caused by 0c390d3

[jamesstout]

Hmmm, sorry fellas. I tested that quite a bit as well...

[gboudreau]

Some of the return codes used in SPConnectionController (but not all of them) are defined in SPAlertSheets.m
If we change them in that file, then we'll need to change the returnCodes used in the conditionals everywhere SPAlertSheets is used.
But I also noticed that sometimes, a regular NSAlert is used, and return codes needs to use the deprecated values, until those NSAlert are updated (to use completionHandler: instead of a didEndSelector: ..?)

[gboudreau]

Overall, removing all deprecated notices would need some effort in that regard.
I suggest just reverting the modified conditionals, until someone takes more time to resolve the issue globally.

[gboudreau]

Of note: NSOKButton => NSModalResponseOK can be kept, as those two are equivalent.

[Jason-Morcos]

Does this fix it for everyone? I accept both the new and legacy conditional values

7805a4b

[jamesstout]

Tested ssh fails last night and looked good (not the bind error though, not sure how to replicate). Didn't get chance to check fav import fails or bundle deletes, but for those two I'd changed them to the withCompletion instantiation. I'll check later.

Just FYI - I'm back to work now and in Hong Kong (GMT+8).

[jamesstout]

fav import failure just displays one OK button and return code isn't checked.
delete bundle - OK and cancel work as expected.
delete favourite - OK and cancel work as expected.

ssh bad username - buttons work as expected
ssh wrong IP - buttons work as expected
ssh wrong port - buttons work as expected
ssh no key or pass - buttons work as expected
ssh bad key (edit ~/.ssh/id_rsa) - buttons work as expected
revert edit and re-select key - connection fails. Maybe not copied to .keys? It is. Needs a bit more testing. Sometimes works sometimes doesn't. But a very rare case for people to be manually editing keys.
cp ~/.ssh/id_rsa.bak to ~/.ssh/id_rsa and re-select key - connection works.