Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating using foreign keys is not working #54

Closed
Sofianio opened this issue Jun 22, 2020 · 3 comments · Fixed by #93 or #118
Closed

Navigating using foreign keys is not working #54

Sofianio opened this issue Jun 22, 2020 · 3 comments · Fixed by #93 or #118
Labels
Bug Something isn't working Highest Priority

Comments

@Sofianio
Copy link

Environment:

Sequel Ace Version: 2.0.1 Build 2029
macOS Version: 1.15.4
MySQL Version: 5.6.28

Description

Linking and navigating isn't working .. copy of issue #3491 in Sequel Pro

Steps To Reproduce:

  • Go to any table with a foreign key
  • Click the foreign key (little arrow)
  • Expected Behavior:
    It used to take you to the related table and show the selected index only, now it only opens the table

Additional Context:

This used to work fine in Sequel Pro 1.1.2, it was soooo helpful.

Please bring it back
@Jason-Morcos Jason-Morcos added the Bug Something isn't working label Jun 22, 2020
@Kaspik Kaspik mentioned this issue Jun 22, 2020
Closed
@Dalamar
Copy link

Dalamar commented Jun 22, 2020 •
edited

This is one of the most valuable features of the Sequel Pro.
Unfortunately, this issue has migrated to the Sequel Ace from the Sequel Pro.
I hope it will be fixed soon.

@Jason-Morcos Jason-Morcos added the Help wanted Extra attention is needed label Jun 22, 2020
@Jason-Morcos
Copy link
Member

I think this is gonna entail some changes to filtering so that filters are set on the table you get to in order to match the params of the foreign key clicked.

@gboudreau gboudreau changed the title Linking and navigating not working Navigating using foreign keys is not working Jun 23, 2020
@gboudreau gboudreau mentioned this issue Jun 24, 2020
Merged
@gboudreau gboudreau linked a pull request Jun 24, 2020 that will close this issue
Fix foreign-key navigation #93
Merged
@Jason-Morcos Jason-Morcos added Fixed & Pending Release and removed Help wanted Extra attention is needed labels Jun 24, 2020
@Jason-Morcos Jason-Morcos mentioned this issue Jun 24, 2020
Merged
jamesstout added a commit to jamesstout/Sequel-Ace that referenced this issue Jun 25, 2020
@jamesstout
Merge branch 'dev' into more-permissions
5c1cd3f 
* dev:
  69-fix-Security-Save Connection divulges query history without warning
  Release Beta 5
  Change host app
  be more platform specific
  Disable more code signing
  Fix code signing
  Update ci_pr_tests.yml
  Fix workflow file
  Move the build script
  Update header
  Add tests on github actions
  Add Github Actions CI running tests on PRs
  Fix tests
  Filter bar should stay open when switching tables, closing app Fixes Sequel-Ace#80
  Fixing navigation using foreign keys; use selection instead of filter Fixes Sequel-Ace#54
  Added missing SPMainQSync() / onMainThread, as needed
  Encourage Users to try Latest Beta Before Submitting Issues
@Jason-Morcos Jason-Morcos mentioned this issue Jun 26, 2020
Merged
@Sofianio
Copy link
Author

I'm Impressed at how fast and efficient this was,
I'm happy to see this feature back :)
Thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix foreign-key navigation
Release 2.1.0 Sequel-Ace/Sequel-Ace
4 participants
@Dalamar @Kaspik @Jason-Morcos @Sofianio