Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequel Ace crashes after selecting database (with 1+ VIEWs) on MariaDB #79

Closed
mgoldbeck opened this issue Jun 23, 2020 · 4 comments · Fixed by #84
Closed

Sequel Ace crashes after selecting database (with 1+ VIEWs) on MariaDB #79

mgoldbeck opened this issue Jun 23, 2020 · 4 comments · Fixed by #84
Assignees
@gboudreau
Labels
Bug Something isn't working Highest Priority

Comments

@mgoldbeck
Copy link

mgoldbeck commented Jun 23, 2020 •
edited by gboudreau

  • Sequel Ace Version: 2.0.2
  • macOS Version: 10.15.4
  • MySQL Version: mysql Ver 15.1 Distrib 10.4.12-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

Description
Selecting a database by the DB selector, Sequel Aces crashes

Steps To Reproduce

  1. open connection
  2. select database

Expected Behaviour
Being able to select a database

Application Specific Information:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull isEqualToString:]: unrecognized selector sent to instance 0x7fff90413c00'
abort() called
terminating with uncaught exception of type NSException
@Jason-Morcos Jason-Morcos added Bug Something isn't working Highest Priority labels Jun 23, 2020
@gboudreau
Copy link
Contributor

The only way I can reproduce is if I select the mysql database; all my own database can be selected without problems...
Are you noticing the same behaviour?

@gboudreau gboudreau self-assigned this Jun 23, 2020
@gboudreau
Copy link
Contributor

gboudreau commented Jun 23, 2020 •
edited

Ah, it's about VIEWs. If your DB has views, it will crash. It's because MariaDB returns different columns in the response of SHOW TABLE STATUS than MySQL.

This was referenced Jun 23, 2020
Closed
Merged
@gboudreau gboudreau changed the title Sequel Ace crashes after selecting DB using MariaDb Sequel Ace crashes after selecting database (with 1+ VIEWs) on MariaDB Jun 23, 2020
@gboudreau gboudreau linked a pull request Jun 23, 2020 that will close this issue
Bugfix: don't crash when Comment column is not last in the SHOW TABLE STATUS result #84
Merged
@gboudreau gboudreau pinned this issue Jun 23, 2020
@Jason-Morcos
Copy link
Member

Please try 2.1.0 beta 3 and let us know if it fixed the issue, @mgoldbeck! https://github.com/Sequel-Ace/Sequel-Ace/releases/tag/2.1.0-beta3

jamesstout added a commit to jamesstout/Sequel-Ace that referenced this issue Jun 24, 2020
@jamesstout
Merge branch 'dev' into more-permissions
dcf8ef6 
* dev: (69 commits)
  Release 2.1.0 Beta 4
  Removed duplicated code (that caused "Main Thread Checker: UI API called on a background thread: -[NSControl stringValue]")
  Crashfix: import Fixes Sequel-Ace#55, Sequel-Ace#74
  Bugfix: don't crash when Comment column is not last in the SHOW TABLE STATUS result Fixes Sequel-Ace#79
  Switch to in-house documentation links
  Notes for MySQLClient Framework 8 indicate support for only MySQL >= 5.6
  Empty password fields, when changing host or username
  Add compatibility notes
  When duplicating a connection, do NOT copy the SSH auth password and SSH key decryption password
  Simplify buttons by their order
  Fix couple of warnings and deprecations
  Removed bundled zlib, and use the system's latest libz instead Ref: sequelpro/sequelpro#1972
  Update readme.md
  Licenses should have URL of an actual company entity
  Add install via homebrew info
  Re-add screenshot
  Remove screenshot
  HTTPS always
  Switch screenshots to sequel-ace.com
  Change some documentation and license links to sequel ace website
  ...

Signed-off-by: James Stout <stoutyhk@gmail.com>

# Conflicts:
#	sequel-ace.xcodeproj/project.pbxproj
@Jason-Morcos Jason-Morcos mentioned this issue Jun 25, 2020
Closed
@Jason-Morcos Jason-Morcos unpinned this issue Jun 28, 2020
@mgoldbeck
Copy link
Author

@Jason-Morcos sorry for late response. Tested it today with the released 2.1.1. Work now :)

btw. I like the new logo much better 👍

@wanyaxing wanyaxing mentioned this issue Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gboudreau gboudreau

Labels
Bug Something isn't working Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: don't crash when Comment column is not last in the SHOW TABLE STATUS result
4 participants
@gboudreau @mgoldbeck @Kaspik @Jason-Morcos