Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter bar should stay open when switching tables, closing app #80

Closed
christianjsanders opened this issue Jun 23, 2020 · 3 comments · Fixed by #98 or #118
Closed

Filter bar should stay open when switching tables, closing app #80

christianjsanders opened this issue Jun 23, 2020 · 3 comments · Fixed by #98 or #118
Labels
Bug Something isn't working
Projects
Future Work

Comments

@christianjsanders
Copy link

At the moment, we have to click the filter icon at the bottom of the screen on the content view to be able to quickly filter the data in our selected table.

Would it be possible to have a setting whereby we can have this auto enabled instead of having to enable it via clicking on each table we look at.

Thanks!
@anotherjames
Copy link

Looks like this might correspond to sequelpro/sequelpro#3670 as well.

@Jason-Morcos Jason-Morcos added PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution Feature Request New feature or request labels Jun 23, 2020
@Jason-Morcos Jason-Morcos added this to To do in Future Work via automation Jun 23, 2020
@gboudreau
Copy link
Contributor

This is actually a bug; the Filter UI should stay visible, when switching tables. And closing the app and re-opening it should also remember the Filter UI visibility.
So if you prefer to always have the Filter UI visible, you toggle it on, and it should always stay on, until you disable it manually.
Will submit a PR to fix this soon.

@gboudreau gboudreau added Bug Something isn't working and removed Feature Request New feature or request labels Jun 24, 2020
@gboudreau gboudreau mentioned this issue Jun 24, 2020
Closed
@gboudreau gboudreau changed the title Setting to have the filter auto enabled on the content view mode Filter bar should stay open when switching tables, closing app Jun 24, 2020
@gboudreau gboudreau mentioned this issue Jun 24, 2020
Merged
@gboudreau gboudreau linked a pull request Jun 24, 2020 that will close this issue
Filter bar should stay open when switching tables, closing app #98
Merged
@Jason-Morcos Jason-Morcos mentioned this issue Jun 24, 2020
Merged
@Jason-Morcos Jason-Morcos added Fixed & Pending Release and removed Bug Something isn't working labels Jun 24, 2020
@gboudreau gboudreau added Bug Something isn't working and removed PR Welcome Issues and fixes available for wide community to help us move forward by creating a PR with solution labels Jun 24, 2020
jamesstout added a commit to jamesstout/Sequel-Ace that referenced this issue Jun 25, 2020
@jamesstout
Merge branch 'dev' into more-permissions
5c1cd3f 
* dev:
  69-fix-Security-Save Connection divulges query history without warning
  Release Beta 5
  Change host app
  be more platform specific
  Disable more code signing
  Fix code signing
  Update ci_pr_tests.yml
  Fix workflow file
  Move the build script
  Update header
  Add tests on github actions
  Add Github Actions CI running tests on PRs
  Fix tests
  Filter bar should stay open when switching tables, closing app Fixes Sequel-Ace#80
  Fixing navigation using foreign keys; use selection instead of filter Fixes Sequel-Ace#54
  Added missing SPMainQSync() / onMainThread, as needed
  Encourage Users to try Latest Beta Before Submitting Issues
@Jason-Morcos Jason-Morcos mentioned this issue Jun 26, 2020
Merged
Future Work automation moved this from To do to Done Jun 26, 2020
@simplenotezy
Copy link

I still have this issue @Kaspik - I am in version 2.1.5 @gboudreau

Should I open a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
No open projects
Future Work
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter bar should stay open when switching tables, closing app
Release 2.1.0 Sequel-Ace/Sequel-Ace
6 participants
@gboudreau @anotherjames @simplenotezy @christianjsanders @Kaspik @Jason-Morcos