Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow : to be used in password #1390

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: allow : to be used in password #1390

merged 1 commit into from
Nov 3, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Oct 11, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

Uses code from the main repo; https://github.com/sequelize/sequelize/blob/b3f03aed681abe0d5e22a9628b083f59f6772305/packages/core/src/utils/url.ts#L37-L43

Fixes #1388

@WikiRik WikiRik marked this pull request as ready for review November 3, 2023 07:16
@WikiRik WikiRik merged commit a52f8bd into main Nov 3, 2023
16 checks passed
@WikiRik WikiRik deleted the WikiRik/1388 branch November 3, 2023 07:16
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 6.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequelize CLI Fails to Authenticate with Postgres DB Containing a ':' in Password
1 participant