Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning when an option flag is meaningless during migration #37

Closed
rayshan opened this issue Aug 28, 2014 · 1 comment
Closed

No warning when an option flag is meaningless during migration #37

rayshan opened this issue Aug 28, 2014 · 1 comment

Comments

@rayshan
Copy link

rayshan commented Aug 28, 2014

E.g.

module.exports =
  up: (migration, DataTypes, done) ->
    migration.createTable tableName, {
      date:
      users:
        type: DataTypes.INTEGER
        allowNull: false
    }, {
      comment: "Table comment."
      meaninglessOptionFlag: true # CLI should warn user about this
    }

Related: sequelize/doc#156

@sdepold
Copy link
Member

sdepold commented Jan 18, 2015

This is no issue with the CLI. It could be part of the sequelize core, but this might be a major change in general.

@sdepold sdepold closed this as completed Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants