Issue with imports - TypeScript < 4

[Davste93]

Is anyone using this with TypeScript?

Not sure why the generated code is doing:

import Sequelize, { DataTypes, Model, Optional } from 'sequelize';

static initModel(sequelize: Sequelize.Sequelize): 

Instead of:

import { Sequelize, DataTypes, Model, Optional } from 'sequelize';

static initModel(sequelize: Sequelize): 

I don't know if Sequelize went from default to named exports, but it seems that this is not working as per sequelize 6.5.0.

[Davste93]

To anyone looking for a quick workaround:

const replace = require('replace-in-file');
...
const auto = new SequelizeAuto(...);
auto.run().then(data => {
  replace.sync({
    ...replaceConfig,
    from: /import Sequelize, \{ DataTypes, Model, Optional \}/g,
    to: 'import { Sequelize, DataTypes, Model, Optional }',
  });

  replace.sync({
    ...replaceConfig,
    from: /Sequelize.Sequelize/g,
    to: 'Sequelize',
  });
});

[steveschmitt]

You need TypeScript 4.x. The syntax

import Sequelize, { DataTypes, Model, Optional } from 'sequelize';

imports the Sequelize namespace, which is used later in the mixin declarations:

  getCustomer!: Sequelize.BelongsToGetAssociationMixin<Customer>;

[Davste93]

Typescript 4.0.5, both in IDE and package.json, as well as node modules.

[steveschmitt]

Hmm, let me try again to reproduce the problem.

[steveschmitt]

No luck. I've tried with Sequelize 6.3.5 and 6.5.0. I've tried with TypeScript 4.0.5 and 4.2.2.

The generated code works for me, while your workaround code gives me an error:

models/product.ts:49:20 - error TS2702: 'Sequelize' only refers to a type, but is being used as a namespace here.

My tsconfig.json looks like:

{
  "compilerOptions": {
    "allowJs": false,
    "checkJs": false,
    "strict": true,
    "declaration": false,
    "module": "commonjs",
    "noImplicitAny": true,
    "esModuleInterop": true,
    "preserveConstEnums": true,
    "removeComments": false,
    "sourceMap": true,
    "target": "ES6",
    "skipLibCheck": true,
    "typeRoots": [
      "node_modules/@types"
    ]
  }
}

[awcchungster]

I can replicate this issue:

"typescript": "^4.1.5"

The "quick workaround" #498 (comment) didn't work for me.

[awcchungster]

I found a resolution by changing my tsconfig

"allowSyntheticDefaultImports": true

[steveschmitt]

I think it works for me because I have

"esModuleInterop": true,

in my tsconfig.json.

@Davste93 can you try that?

[cesar3030]

To anyone looking for a quick workaround:

const replace = require('replace-in-file');
...
const auto = new SequelizeAuto(...);
auto.run().then(data => {
  replace.sync({
    ...replaceConfig,
    from: /import Sequelize, \{ DataTypes, Model, Optional \}/g,
    to: 'import { Sequelize, DataTypes, Model, Optional }',
  });

  replace.sync({
    ...replaceConfig,
    from: /Sequelize.Sequelize/g,
    to: 'Sequelize',
  });
});

Thanks for the lead, I had to do a few changes to have it working:

replace.sync({
  files: './src/models/*.ts',
  from: /import Sequelize, \{ DataTypes, Model, Optional \} from 'sequelize';/g,
  to: "import { DataTypes, Model, Optional } from 'sequelize';\nimport * as Sequelize from 'sequelize';"
});

[steveschmitt]

Fixed in 0.8.2