Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #122 #186

Merged
merged 23 commits into from
Nov 4, 2017
Merged

Issue #122 #186

merged 23 commits into from
Nov 4, 2017

Conversation

RobinBuschmann
Copy link
Member

@RobinBuschmann RobinBuschmann commented Nov 2, 2017

  • adds ThoughOptions support for Many-to-Many relations
  • complete rewrite of association implementation

closes #122

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #186 into master will decrease coverage by 0.13%.
The diff coverage is 97.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   96.85%   96.71%   -0.14%     
==========================================
  Files         100      115      +15     
  Lines         921     1004      +83     
  Branches      125      129       +4     
==========================================
+ Hits          892      971      +79     
- Misses          9       15       +6     
+ Partials       20       18       -2
Impacted Files Coverage Δ
lib/annotations/association/BelongsTo.ts 100% <100%> (ø) ⬆️
lib/models/association/HasAssociation.ts 100% <100%> (ø)
lib/services/association.ts 97.43% <100%> (+4.36%) ⬆️
lib/services/models.ts 92.24% <100%> (ø) ⬆️
lib/models/BaseSequelize.ts 95.74% <100%> (+0.62%) ⬆️
lib/annotations/association/BelongsToMany.ts 100% <100%> (ø) ⬆️
lib/models/association/BelongsToAssociation.ts 100% <100%> (ø)
lib/annotations/association/HasMany.ts 100% <100%> (ø) ⬆️
lib/annotations/association/HasOne.ts 100% <100%> (ø) ⬆️
lib/enums/Association.ts 100% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581fd57...3532589. Read the comment docs.

@RobinBuschmann RobinBuschmann merged commit c569be6 into master Nov 4, 2017
@RobinBuschmann RobinBuschmann deleted the issue-#122 branch November 4, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ThroughOptions
2 participants