Skip to content

Commit

Permalink
feat(types): add TypeScript 5.2 support (#16442)
Browse files Browse the repository at this point in the history
  • Loading branch information
esetnik committed Sep 8, 2023
1 parent e4c780c commit 367caf3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ts-version: ["4.1", "4.2", "4.3", "4.4", "4.5", "4.6", "4.7", "4.8"]
ts-version: ["4.1", "4.2", "4.3", "4.4", "4.5", "4.6", "4.7", "4.8", "4.9", "5.0", "5.1", "5.2"]
name: TS Typings (${{ matrix.ts-version }})
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:
env:
DIALECT: snowflake
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -71,7 +71,7 @@
"@octokit/rest": "^18.12.0",
"@octokit/types": "^6.34.0",
"@types/chai": "^4.3.0",
"@types/lodash": "4.14.182",
"@types/lodash": "4.14.197",
"@types/mocha": "^9.0.0",
"@types/node": "^16.11.17",
"@types/sinon": "^10.0.6",
Expand Down
11 changes: 2 additions & 9 deletions src/transaction.d.ts
Expand Up @@ -29,14 +29,14 @@ export class Transaction {
/**
* Returns possible options for row locking
*/
static get LOCK(): LOCK;
static get LOCK(): typeof LOCK;

/**
* Same as its static version, but can also be called on instances of
* transactions to get possible options for row locking directly from the
* instance.
*/
get LOCK(): LOCK;
get LOCK(): typeof LOCK;
}

// tslint:disable-next-line no-namespace
Expand Down Expand Up @@ -131,13 +131,6 @@ export enum LOCK {
NO_KEY_UPDATE = 'NO KEY UPDATE',
}

interface LOCK {
UPDATE: LOCK.UPDATE;
SHARE: LOCK.SHARE;
KEY_SHARE: LOCK.KEY_SHARE;
NO_KEY_UPDATE: LOCK.NO_KEY_UPDATE;
}

/**
* Options provided when the transaction is created
*/
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Expand Up @@ -1206,10 +1206,10 @@
resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.12.tgz#d70faba7039d5fca54c83c7dbab41051d2b6f6cb"
integrity sha512-Hr5Jfhc9eYOQNPYO5WLDq/n4jqijdHNlDXjuAQkkt+mWdQR+XJToOHrsD4cPaMXpn6KO7y2+wM8AZEs8VpBLVA==

"@types/lodash@4.14.182":
version "4.14.182"
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.182.tgz#05301a4d5e62963227eaafe0ce04dd77c54ea5c2"
integrity sha512-/THyiqyQAP9AfARo4pF+aCGcyiQ94tX/Is2I7HofNRqoYLgN1PBoOWu2/zTA5zMxzP5EFutMtWtGAFRKUe961Q==
"@types/lodash@4.14.197":
version "4.14.197"
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.197.tgz#e95c5ddcc814ec3e84c891910a01e0c8a378c54b"
integrity sha512-BMVOiWs0uNxHVlHBgzTIqJYmj+PgCo4euloGF+5m4okL3rEYzM2EEv78mw8zWSMM57dM7kVIgJ2QDvwHSoCI5g==

"@types/minimist@^1.2.0":
version "1.2.2"
Expand Down

0 comments on commit 367caf3

Please sign in to comment.