Skip to content

Commit

Permalink
fix: support TS 4.9 and drop support TS 4.5 (#15284)
Browse files Browse the repository at this point in the history
  • Loading branch information
WikiRik committed Nov 15, 2022
1 parent ce5180d commit 3b1ba33
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Expand Up @@ -111,7 +111,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ts-version: ["4.5", "4.6", "4.7", "4.8"]
ts-version: ["4.6", "4.7", "4.8", "4.9"]
name: TS Typings (${{ matrix.ts-version }})
runs-on: ubuntu-latest
needs: lint
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -120,7 +120,7 @@
"tedious": "15.1.1",
"ts-node": "10.9.1",
"typedoc": "0.23.21",
"typescript": "4.8.4"
"typescript": "4.9.3"
},
"peerDependenciesMeta": {
"pg": {
Expand Down
3 changes: 0 additions & 3 deletions src/dialects/abstract/data-types-utils.ts
Expand Up @@ -42,9 +42,6 @@ export function normalizeDataType(

export function dataTypeClassOrInstanceToInstance(Type: DataTypeClassOrInstance): DataTypeInstance {
return typeof Type === 'function'
// TODO [2022-12-01]: Remove this eslint-disable once we drop support for TypeScript 4.5
// eslint-disable-next-line @typescript-eslint/prefer-ts-expect-error -- typescript 4.5 narrows Class to "never" here, but typescript 4.6 handles it correctly
// @ts-ignore
? new Type()
: Type;
}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Expand Up @@ -8707,10 +8707,10 @@ typedoc@0.23.21:
minimatch "^5.1.0"
shiki "^0.11.1"

typescript@4.8.4:
version "4.8.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.8.4.tgz#c464abca159669597be5f96b8943500b238e60e6"
integrity sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==
typescript@4.9.3:
version "4.9.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.3.tgz#3aea307c1746b8c384435d8ac36b8a2e580d85db"
integrity sha512-CIfGzTelbKNEnLpLdGFgdyKhG23CKdKgQPOBc+OUNrkJ2vr+KSzsSV5kq5iWhEQbok+quxgGzrAtGWCyU7tHnA==

uc.micro@^1.0.1, uc.micro@^1.0.5:
version "1.0.6"
Expand Down

0 comments on commit 3b1ba33

Please sign in to comment.