fix(types): drop excess argument for upsert (#14156)

sequelize · Feb 24, 2022 · c2459f0 · c2459f0
1 parent ae6a3f4
commit c2459f0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/dialects/abstract/query-interface.d.ts b/src/dialects/abstract/query-interface.d.ts
@@ -485,13 +485,12 @@ export class QueryInterface {
   /**
    * Inserts or Updates a record in the database
    */
-  public upsert(
+  public upsert<M extends Model>(
     tableName: TableName,
     insertValues: object,
     updateValues: object,
     where: object,
-    model: ModelType,
-    options?: QueryOptions
+    options?: QueryOptionsWithModel<M>
   ): Promise<object>;
 
   /**

diff --git a/test/types/query-interface.ts b/test/types/query-interface.ts
@@ -223,7 +223,7 @@ async function test() {
 
   class TestModel extends Model {}
 
-  await queryInterface.upsert("test", {"a": 1}, {"b": 2}, {"c": 3}, TestModel, {});
+  await queryInterface.upsert("test", {"a": 1}, {"b": 2}, {"c": 3}, {model: TestModel});
 
   await queryInterface.insert(null, 'test', {});
 }