[Feature] Add findByPks convenience method

[ustun]

A common thing we do is searching for model that match a given id set. This is not that hard with the following clause: Model.findAll({where: {id: {[Op.in]: [1, 2, 3]}}}), however it might be easier if a findByPks method was added so that one would do Model.findByPks([1,2,3]) and/or Model.findByPks(1,2,3).

Rails has this: https://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html#method-i-find

TypeORM has this: https://typeorm.io/#/entity-manager-api Search for findByIds

I think if this will be added, we should investigate what other convenience methods could be added. For example, there is an open issue about adding exists: #10187

[fboechats]

@papb I was taking a look in this feature and should we create another method or can we let findByPk receive more than one parameter??

[papb]

@fboechats Hello. I think it's better to create a new method, model.findByPks(). Would you like to take this?

[fboechats]

@papb Sure, I will try to make a PR with this feature

[fboechats]

@papb Can I get some help on how to debug the method a created?? Tried using the vscode debug tool, but didn't work as expected.

[papb]

@fboechats It usually works for me, I place some breakpoints and navigate through it. Can you be more specific?

[fboechats]

@papb Sure, it got some errors. I guess it's because I'm running mysql on docker. So now I'm trying to use Mocha tests to kind of debug.

[papb]

@fboechats To work on this feature, which is not dialect-specific, I think you should just use sqlite instead, it is so much easier...

const { Sequelize } = require("sequelize");
const sequelize = new Sequelize("sqlite::memory:");

// do your work

[fboechats]

@papb I opened a PR with some initial idea and simple tests.

[netochaves]

@papb Can I get some help on how to debug the method a created?? Tried using the vscode debug tool, but didn't work as expected.

Hi @fboechats if you're still trying to debug the test, you can do it with inspect-brk flag, and use debugger to create a breakpoint.

[github-actions]

This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

[tapiwakundi]

@ustun @papb This issue is still open and I'm looking for a first issue to contribute. Is this still something we want to work on?

[ephys]

@tapiwakundi Sure! Feel free to give it a try