Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tedious 8.3.0 deprecation #12181

Closed
2 of 7 tasks
UziTech opened this issue Apr 27, 2020 · 0 comments · Fixed by #12182
Closed
2 of 7 tasks

tedious 8.3.0 deprecation #12181

UziTech opened this issue Apr 27, 2020 · 0 comments · Fixed by #12182

Comments

@UziTech
Copy link
Contributor

UziTech commented Apr 27, 2020

Issue Description

tedious will require calling .connect() on the connection in v9 it currently reports a deprecation in v8.3.0

What are you doing?

using tedious v8.3.0 to connect to MS SQL Server

What do you expect to happen?

No deprecation notice

What is actually happening?

tedious is showing deprecation notice:

In the next major version of `tedious`, creating a new `Connection`
instance will no longer establish a connection to the server automatically. Please use
the new `connect` helper function or call the `.connect` method on the newly created
`Connection` object to silence this message.

Additional context

The tedious PR with this deprecation: tediousjs/tedious#1069

Environment

  • Sequelize version: 5.21.7
  • Node.js version: 12.6.1
  • Operating System: Windows 10

Issue Template Checklist

How does this problem relate to dialects?

  • I think this problem happens regardless of the dialect.
  • I think this problem happens only for the following dialect(s): MSSQL
  • I don't know, I was using PUT-YOUR-DIALECT-HERE, with connector library version XXX and database version XXX

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I don't know how to start, I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant