fix(types): update return type of Model.update

[guyellis]

Pull Request Checklist

Please make sure to review and check all of these items:

• Did you update the typescript typings accordingly (if applicable)?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

As per the docs in the type I've updated the type.

A few lines above the change is a description where the update() method can return 2 types. I added the 2nd type.

[guyellis]

Failing test looks like a random issue unrelated to this PR:

  1 failing

  1) [SQLITE] Transaction
       fails with SQLITE_BUSY when retry.match is changed:
     AssertionError: expected promise to be rejected with an error including 'SQLITE_BUSY: database is locked' but it was fulfilled with [ undefined, undefined ]
      at assertIfNotNegated (node_modules/chai-as-promised/lib/chai-as-promised.js:68:19)
      at /home/runner/work/sequelize/sequelize/node_modules/chai-as-promised/lib/chai-as-promised.js:183:17
      at async Context.<anonymous> (test/integration/transaction.test.js:739:9)

[ephys]

Thank you for your PR!

I think we could handle this like Model.count: have two method signatures:

• one with option.returning set to true that returns [affectedCount: number, affectedRows: M[]]
• one without option.returning (or set to false) that returns [affectedCount: number]

[ephys]

Also you're right, the sqlite issue is something that started happening randomly recently but unrelated to your PR

[guyellis]

I think we could handle this like Model.count: have two method signatures:

• one with option.returning set to true that returns [affectedCount: number, affectedRows: M[]]
• one without option.returning (or set to false) that returns [affectedCount: number]

That was a great idea. Thank you! I've made the changes and pushed them. LMK what you think. Thanks.

[ephys]

Thanks, I think we're good to go :)
Merging another PR first then I'll update & merge this one

[guyellis]

Thanks, I think we're good to go :) Merging another PR first then I'll update & merge this one

Thank you for doing this! You are awesome! 🏆

[ruiaraujolink]

Hi, this PR create a problem, when I pass an array of attributes this happens

[WikiRik]

Hi, this PR create a problem, when I pass an array of attributes this happens

Hi! This should be fixed with #14184 right? That PR will be reviewed soon and then we will release a new version

[ruiaraujolink]

Hi, this PR create a problem, when I pass an array of attributes this happens

Hi! This should be fixed with #14184 right? That PR will be reviewed soon and then we will release a new version

I think so, thanks.

[github-actions]

🎉 This PR is included in version 7.0.0-alpha.11 🎉

The release is available on:

• npm package (@release-v7 dist-tag)
• GitHub release

Your semantic-release bot 📦🚀