fix: kill connection on commit/rollback error (v7) #14574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephys
changed the title
|
Blocked by #14652 |
WikiRik
approved these changes
Jun 19, 2022
WikiRik
requested changes
Jun 19, 2022
|
The CLS change I did is causing weird behaviors, I'm postponing it to when we move to the built-in AsyncLocalStorage |
|
Hmm, something goes wrong and I don't think it's connected to this PR EDIT: ibmdb/node-ibm_db#865 |
|
Aah, nice. ibm_db is fixed :) |
WikiRik
previously approved these changes
Jun 20, 2022
…lize into ephys/forward-port-14535
WikiRik
approved these changes
Jun 20, 2022
|
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports PR #14535 to v7
This PR is dependent on #14572 being merged first, as it needs to use
integration/support.ts