fix: kill connection on commit/rollback error

[ephys]

Pull Request Checklist

• Have you added new tests to prevent regressions?
• Does yarn test or yarn test-DIALECT pass with this change (including linting)?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

This is an attempt at fixing #10858. I don't know if it'll completely fix it, so in doubt I'm not closing that issue.

What was going on?

If an error occurred during a transaction commit or rollback (such as a network error), Sequelize would call transaction.cleanup(), which released the connection to the pool.

The problem is that if an error occurred, we cannot guarantee that the transaction did actually commit or roll back. It may still be active. Releasing the connection to the pool does not kill the connection, and it will end up used by other queries - unknowingly running in another transaction.

The fix

This PR changes that by taking the drastic approach of killing the connection if an error occurred during COMMIT TRANSACTION or ROLLBACK TRANSACTION.

[sdepold]

Regarding the test, I guess you could stub rollbackTransaction / commitTransaction during a test?

[ephys]

Yes, I think that's how I'll do that :)

[sdepold]

I approved it. Don't know how strong I feel about the .length change. You decide

[github-actions]

🎉 This PR is included in version 6.20.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀