New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql): match aggregate errors #14784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a test for this? Or will the fact that the referenced pr no longer fail, suffice?
I was thinking about that as well but I couldn't come up with a proper new test. The referenced PR should be fine. Earlier I was also thinking if this code should only be used with the new version of tedious but I decided not to since no behaviour should be changed in the older versions of tedious |
🎉 This PR is included in version 7.0.0-alpha.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@ephys check this out for the multiple tedious errors. Maybe we should not return the errors directly but first collect them all |
Definitely should :) |
Separate PR, it's not related to either :) |
I know, it's just that you're working on those PRs and might have encountered some issues because of this |
Pull Request Checklist
Please make sure to review and check all of these items:
yarn test
oryarn test-DIALECT
pass with this change (including linting)?Description Of Change
Adds support for aggregate errors as introduced in tedious 14.5.0
Unblocks #14484