Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): match aggregate errors #14784

Merged
merged 3 commits into from Aug 8, 2022
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Jul 22, 2022

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Adds support for aggregate errors as introduced in tedious 14.5.0
Unblocks #14484

@WikiRik WikiRik marked this pull request as draft July 22, 2022 15:34
@WikiRik WikiRik marked this pull request as ready for review July 22, 2022 18:16
@WikiRik WikiRik requested review from ephys and sdepold July 22, 2022 18:17
Copy link
Member

@sdepold sdepold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for this? Or will the fact that the referenced pr no longer fail, suffice?

@WikiRik
Copy link
Member Author

WikiRik commented Aug 8, 2022

I was thinking about that as well but I couldn't come up with a proper new test. The referenced PR should be fine. Earlier I was also thinking if this code should only be used with the new version of tedious but I decided not to since no behaviour should be changed in the older versions of tedious

@WikiRik WikiRik merged commit 00c1019 into main Aug 8, 2022
@WikiRik WikiRik deleted the WikiRik/tedious-aggregate-errors branch August 8, 2022 09:59
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@WikiRik
Copy link
Member Author

WikiRik commented Sep 23, 2022

@ephys check this out for the multiple tedious errors. Maybe we should not return the errors directly but first collect them all

@ephys
Copy link
Member

ephys commented Sep 23, 2022

Definitely should :)

@WikiRik
Copy link
Member Author

WikiRik commented Sep 23, 2022

Can you add that to #14505 or #14999 ? Or a third separate PR?

@ephys
Copy link
Member

ephys commented Sep 23, 2022

Separate PR, it's not related to either :)

@WikiRik
Copy link
Member Author

WikiRik commented Sep 23, 2022

I know, it's just that you're working on those PRs and might have encountered some issues because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants