Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support TS 4.9 and drop support TS 4.5 #15284

Merged
merged 1 commit into from Nov 15, 2022
Merged

fix: support TS 4.9 and drop support TS 4.5 #15284

merged 1 commit into from Nov 15, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 15, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Now TS 4.9 is out we need to add that to our CI. We also drop support for TS 4.5 per our version policy since it has been out for a year.

Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are green, let's go

Do you plan on adding 4.9 to our v6 CI?

@WikiRik
Copy link
Member Author

WikiRik commented Nov 15, 2022

Do you plan on adding 4.9 to our v6 CI?

Yes, in #15059 probably. But I need to figure out what to do with the Node 10 tests there, maybe I just need to undo some TS migration things

@WikiRik WikiRik merged commit 3b1ba33 into main Nov 15, 2022
@WikiRik WikiRik deleted the WikiRik/TS-4.9 branch November 15, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants