Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nestMode option for managed transactions #16143

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Conversation

ephys
Copy link
Member

@ephys ephys commented Jun 18, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR implements the feature described here: #13741 (comment), except for withAlsTransaction which we can always add if there is an actual need for it

Breaking changes

  • Normalized the casing of our transaction-related enums. It's only a typing change, because we never actually exposed the value as a global export.
    • LOCK -> Lock
    • ISOLATION_LEVELS -> TransactionType
    • TRANSACTION_TYPES -> TransactionType

@ephys ephys marked this pull request as draft June 18, 2023 16:53
@ephys ephys marked this pull request as ready for review June 18, 2023 17:30
@ephys ephys self-assigned this Jun 18, 2023
@ephys ephys requested a review from a team June 18, 2023 17:30
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing you forgot to update but apart from that it's good

packages/core/src/deferrable.ts Outdated Show resolved Hide resolved
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@ephys ephys added this pull request to the merge queue Jun 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 18, 2023
@WikiRik WikiRik added this pull request to the merge queue Jun 18, 2023
Merged via the queue into main with commit c4eef63 Jun 18, 2023
49 checks passed
@WikiRik WikiRik deleted the ephys/new-cls-options branch June 18, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants