Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update transaction documentation #419

Merged
merged 6 commits into from Jun 25, 2023
Merged

feat: update transaction documentation #419

merged 6 commits into from Jun 25, 2023

Conversation

ephys
Copy link
Member

@ephys ephys commented Mar 4, 2023

A branch I wrote a while ago but apparently never sent?

This documents the changes made in Sequelize 7 regarding transactions

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this we've brought back the usage of CLS. Can you update that?

docs/other-topics/transactions.md Outdated Show resolved Hide resolved
@ephys ephys requested a review from WikiRik May 27, 2023 16:15
@ephys ephys marked this pull request as ready for review May 27, 2023 16:15
@WikiRik
Copy link
Member

WikiRik commented Jun 19, 2023

I forgot about this one, should we revisit this after #330 ? (I'll finish the review of the associations folder soon) Also with sequelize/sequelize#16143 being merged now.

@ephys
Copy link
Member Author

ephys commented Jun 20, 2023

Sure! I'll update it with the new info once the main PR is merged

@ephys
Copy link
Member Author

ephys commented Jun 25, 2023

@WikiRik CI fails due to an issue with our Netlify deployment that I have not inspected, but the PR is ready to review

@WikiRik
Copy link
Member

WikiRik commented Jun 25, 2023

It seems to have deployed fine; https://64989bbcdd20973b67da64a0--sequelize-site.netlify.app/
It's just that the result to the CI failed for some reason, I saw this on the draft build earlier this week as well

@ephys ephys merged commit 23c1144 into main Jun 25, 2023
1 check failed
@ephys ephys deleted the ephys/als branch June 25, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants