Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSCCE CI pipeline broken after dropping support for Node 14 #16434

Closed
3 of 6 tasks
Hornwitser opened this issue Aug 29, 2023 · 1 comment · Fixed by sequelize/sequelize-sscce#261
Closed
3 of 6 tasks
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.

Comments

@Hornwitser
Copy link
Contributor

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Bug Description

After #16058 code which uses Node.js features that are supported in Node.js v16, but not v14 have made its way into the code base, but the CI pipeline for the SSCCE repository which people are instructed to use to demonstrate problems in Sequelize have not been updated to reflect this. Consequently it fails to run.

Reproducible Example

Here is the link to the SSCCE for this issue: sequelize/sequelize-sscce#260

What do you expect to happen?

SSCCE CI Pipeline should work with Sequelize v7.

What is actually happening?

Tests throw an error before user code is even run:

An unhandled rejection occurred:
/home/runner/work/sequelize-sscce/sequelize-sscce/node_modules/@sequelize/core/lib/associations/belongs-to.js:140
      newForeignKeyAttribute.onDelete ??= newForeignKeyAttribute.allowNull !== false ? "SET NULL" : "CASCADE";
                                      ^^^

SyntaxError: Unexpected token '??='

Environment

  • Sequelize version: v7.0.0-alpha.27
  • Node.js version: 14.21.3 (CI pipeline tries to run with an unsupported version)
  • If TypeScript related: TypeScript version: n/a
  • Database & Version: all dialects
  • Connector library & Version: n/a

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@Hornwitser Hornwitser added pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: bug labels Aug 29, 2023
@WikiRik WikiRik added type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. and removed type: bug pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet labels Aug 29, 2023
@Hornwitser
Copy link
Contributor Author

I guess my help is not needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
2 participants