fix: make CI pipeline run v7 on Node.js >= 16 #262
Closed
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With sequelize/sequelize#16058 v14 is no longer supported on Sequelize v7. Update the CI pipeline to only run v7 tests if Node.js version is 16 or higher. Also fix sqlite tests only being ran on Node.js v14.
|
My apologies, it seems I was too quick with creating my own pull request. Thanks for the report and the keen eye about sqlite. I have updated that in the other PR as well. Feel free to give that a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sequelize/sequelize#16058 v14 is no longer supported on Sequelize v7. Update the CI pipeline to only run v7 tests if Node.js version is 16 or higher.
Also fix sqlite tests only being ran on Node.js v14.
Resolves sequelize/sequelize#16434