Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop leaking "smart" variable #1051

Merged
merged 13 commits into from Nov 21, 2013
Merged

Stop leaking "smart" variable #1051

merged 13 commits into from Nov 21, 2013

Commits on Nov 11, 2013

  1. Scope 'smart' variable correctly

    @elliotf
    elliotf committed Nov 11, 2013
    Copy the full SHA
    8fb8bbc View commit details
    Browse the repository at this point in the history

  2. Make variable definition pattern consistent

    @elliotf
    elliotf committed Nov 11, 2013
    Copy the full SHA
    501baf7 View commit details
    Browse the repository at this point in the history

  3. Move var definition to top of scope

    @elliotf
    elliotf committed Nov 11, 2013
    Copy the full SHA
    fe8283b View commit details
    Browse the repository at this point in the history

  4. Stop scopeOptions global leak

    @elliotf
    elliotf committed Nov 11, 2013
    Copy the full SHA
    bb656ff View commit details
    Browse the repository at this point in the history

  5. Stop beforeHook, afterHook global leaks

    @elliotf
    elliotf committed Nov 11, 2013
    Copy the full SHA
    146f927 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2013

  1. Stop setting global variable 'columnTypes' on error

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    fbb536d View commit details
    Browse the repository at this point in the history

  2. Force mocha to check for global leaks

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    afdf129 View commit details
    Browse the repository at this point in the history

  3. Revert global leak check to have passing tests 

    This reverts commit afdf129.
    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    ce35a07 View commit details
    Browse the repository at this point in the history

  4. Stop leaking global 'valueOutOfScope'

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    6f5a408 View commit details
    Browse the repository at this point in the history

  5. Move variable declaration to top of scope

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    d179778 View commit details
    Browse the repository at this point in the history

  6. Stop leaking global '_value'

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    82adf68 View commit details
    Browse the repository at this point in the history

  7. Stop leaking global 'type'

    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    77a8433 View commit details
    Browse the repository at this point in the history

  8. Force mocha to check for global leaks 

    Hopefully all global leaks should be gone.
    @elliotf
    elliotf committed Nov 20, 2013
    Copy the full SHA
    f439431 View commit details
    Browse the repository at this point in the history