-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query-generator): convert numbers to date types #10569
Conversation
Seems like it doesn't like the timezone being included for some reason, it works fine locally.. |
@sushantdhiman I'll be pretty busy with work for a while, can you look into this? |
package.json
Outdated
@@ -121,15 +121,15 @@ | |||
"test-docker-integration": "env-cmd $npm_package_options_env_cmd npm run test-integration", | |||
"docs": "esdoc && cp docs/ROUTER esdoc/ROUTER && cp docs/favicon.ico esdoc/favicon.ico", | |||
"teaser": "node scripts/teaser", | |||
"test-unit": "mocha --require scripts/mocha-bootload --globals setImmediate,clearImmediate --exit --check-leaks --colors -t 30000 --reporter spec \"test/unit/**/*.js\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to the issue? or is it just not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't really mean to commit this but no, this isn't needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can put this in a separate pr then so if it would cause trouble at some end it's easier to pin it down using bisect
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Fixes #10563
Also renamed some tests as using mocha's
-f GREB
doesn't work well with$
.