Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize a few code paths #10570

Merged
merged 2 commits into from Mar 19, 2019
Merged

chore: optimize a few code paths #10570

merged 2 commits into from Mar 19, 2019

Conversation

SimonSchick
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Basically #10553 but without the forEach changes.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #10570 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10570      +/-   ##
==========================================
+ Coverage   96.18%   96.18%   +<.01%     
==========================================
  Files          92       92              
  Lines        9007     9009       +2     
==========================================
+ Hits         8663     8665       +2     
  Misses        344      344
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 94.61% <100%> (ø) ⬆️
lib/model.js 96.67% <100%> (ø) ⬆️
lib/utils.js 98.35% <100%> (+0.01%) ⬆️
lib/sequelize.js 96.27% <100%> (ø) ⬆️
lib/deferrable.js 71.42% <100%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a7931...7954ea1. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 3578062 into master Mar 19, 2019
@sushantdhiman sushantdhiman deleted the chore/optimize branch March 19, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants