docs(sequelize): update constructor define docs #10675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSchick
approved these changes
Mar 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #10675 +/- ##
=======================================
Coverage 96.2% 96.2%
=======================================
Files 93 93
Lines 9011 9011
=======================================
Hits 8669 8669
Misses 342 342
Continue to review full report at Codecov.
|
eseliger
approved these changes
Mar 31, 2019
|
🎉 This PR is included in version 5.2.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ALiangLiang
pushed a commit
to ALiangLiang/sequelize
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since
sequelize.definehas started to be called "legacy" andModel.inithas been preferred, and since the current implementation ofsequelize.definesimply callsModel.initinternally, I think this minor change in the docs is desirable.Question: I've added an
@linkto the.jsdocumentation but I left it as plain-text in the.d.tsdocumentation, because I didn't see any other@linkon the.d.tsfiles. Should I have done something different? Also please see #10673.