Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): make it easier for newcomers #10676

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

papb
Copy link
Member

@papb papb commented Mar 31, 2019

Description of change

Adding a few more things to the README to give important information more quickly to newcomers. I think the README should be a place where a quick glance should pass a lot of information, especially for people who don't know the project.

Copy link
Contributor

@SimonSchick SimonSchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

README.md Outdated
@@ -16,7 +16,9 @@

Sequelize is a promise-based Node.js ORM for Postgres, MySQL, MariaDB, SQLite and Microsoft SQL Server. It features solid transaction support, relations, eager and lazy loading, read replication and more.

Sequelize follows [SEMVER](http://semver.org). Supports Node v6 and above to use ES6 features.
Sequelize follows [SEMVER](http://semver.org). Supports Node v6 and above to use ES6 features. [Official TypeScript typings are also included](http://docs.sequelizejs.com/manual/typescript).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts a little with my PR: #10677

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonSchick oh, nice PR 😬 I've retracted this part of mine then.

But, I think you should update your PR with some mention to TypeScript more closer to the beginning of the README. Supporting TypeScript is a huge plus that IMO should be mentioned ASAP. Newcomers that take a glance at the README should see that TS is supported 😬 What do you think?

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #10676 into master will decrease coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10676      +/-   ##
==========================================
- Coverage    96.2%   95.38%   -0.82%     
==========================================
  Files          93       90       -3     
  Lines        9011     8800     -211     
==========================================
- Hits         8669     8394     -275     
- Misses        342      406      +64
Impacted Files Coverage Δ
lib/dialects/mariadb/query-generator.js 10.63% <0%> (-87.24%) ⬇️
lib/dialects/mariadb/data-types.js 50.98% <0%> (-47.06%) ⬇️
lib/dialects/postgres/connection-manager.js 90.76% <0%> (-3.85%) ⬇️
lib/dialects/abstract/connection-manager.js 88.39% <0%> (-1.79%) ⬇️
lib/query-interface.js 90.75% <0%> (-1.46%) ⬇️
lib/sequelize.js 95.65% <0%> (-0.63%) ⬇️
lib/dialects/abstract/query-generator.js 97.39% <0%> (-0.18%) ⬇️
lib/dialects/mariadb/index.js
lib/dialects/mariadb/connection-manager.js
lib/dialects/mariadb/query.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfe7e5...8a6f0bb. Read the comment docs.

@sushantdhiman sushantdhiman merged commit c9e48e4 into sequelize:master Apr 2, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

ALiangLiang pushed a commit to ALiangLiang/sequelize that referenced this pull request Apr 3, 2019
@papb papb deleted the patch-2 branch May 5, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants