Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correctly format code block #10745

Merged
merged 1 commit into from
Apr 10, 2019
Merged

docs: correctly format code block #10745

merged 1 commit into from
Apr 10, 2019

Conversation

alexframe
Copy link
Contributor

@alexframe alexframe commented Apr 10, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Resolves #10744 by changing incorrectly formatted code block from json to javascript.

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #10745 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10745   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          93       93           
  Lines        8980     8980           
=======================================
  Hits         8649     8649           
  Misses        331      331

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbb318...1f42d6a. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 7c3c18a into sequelize:master Apr 10, 2019
@alexframe alexframe deleted the patch-1 branch April 10, 2019 05:25
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants