fix(mariadb): properly escape json path key #11089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11089 +/- ##
==========================================
- Coverage 89.55% 87.14% -2.42%
==========================================
Files 92 92
Lines 8913 8913
==========================================
- Hits 7982 7767 -215
- Misses 931 1146 +215
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.8.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@sushantdhiman thank you for the fix and time.
Once again thank you for this library and updates 🙏 |
…ndle-deadlock * 'master' of github.com:sequelize/sequelize: (22 commits) docs(migrations): use timestamps with seed (sequelize#11160) test: remove redundant test (sequelize#11156) fix(types): add literal to possible where options (sequelize#10990) fix(model): don't alter original scopes when combining them (sequelize#10722) fix(types): relax order typing (sequelize#10802) fix(types): add string to Includeable (sequelize#11003) docs(models-definition): correct spelling mistakes (sequelize#11147) fix(types): silent option for update (sequelize#11115) fix: update sequelize-pool (sequelize#11134) feat(hooks): beforeDisconnect / afterDisconnect (sequelize#11117) refactor: remove unused _templateSettings refactor(query-generation): remove lodash string templates (sequelize#11122) docs: improve datatype docs docs: explain defaults/where behavior for find/create (sequelize#11069) build: remove test*.js from .gitignore (sequelize#11108) docs(data-types): extending types fix(sequelize.close): update sequelize-pool (sequelize#11101) build: update dependencies (sequelize#11099) docs(migrations): foreign key example (sequelize#11097) fix(mariadb): properly escape json path key (sequelize#11089) ...
|
Is there any chance this will be released also as part of Sequelize 4.x? |
|
@jansoltis - Out of curiosity, may I ask what is preventing you from updating to v5? (just to better understand the problems faced by the user base) |
|
@papb That's a good point. Somehow I thought it is difficult for us to update to v5, but now that I'm looking at the release notes it seems doable (there are still quite some changes though). We were planning to update at some point anyway so perhaps it's the right time. Thank you for asking the right questions! |
|
@jansoltis If you can backport these changes to v4 we can push new release for you |
|
🎉 This PR is included in version 7.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@sushantdhiman Why did semantic-release bot trigger for so many PRs for v7? |
|
Not sure @papb , I will delete that release |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Properly escape JSON path keys for mariadb dialect