fix(postgres): schema for index and relations

[vanthome]

Relations and Indexes created from models that have set a schema are not properly prefixed with the schema. This patch solves this.

Pull Request check-list

Please make sure to review and check all of these items:

• Does npm run test or npm run test-DIALECT pass with this change (including linting)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Have you added new tests to prevent regressions?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

In several cases, the schema prefix was not applied for generated indexes and related tables. This PR fixes this.

Fixes #11276.

[codecov]

Codecov Report

Merging #11274 into master will decrease coverage by 2.1%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master   #11274      +/-   ##
==========================================
- Coverage   96.31%    94.2%   -2.11%     
==========================================
  Files          94       94              
  Lines        9106     9115       +9     
==========================================
- Hits         8770     8587     -183     
- Misses        336      528     +192

Impacted Files	Coverage Δ
lib/model.js	96.46% <ø> (ø)	⬆️
lib/dialects/abstract/query-generator.js	97.08% <50%> (-0.53%)	⬇️
lib/dialects/postgres/query-generator.js	94.37% <87.5%> (-0.16%)	⬇️
lib/dialects/mysql/query.js	15.12% <0%> (-83.2%)	⬇️
lib/dialects/mysql/connection-manager.js	29.09% <0%> (-67.28%)	⬇️
lib/dialects/mysql/data-types.js	43.75% <0%> (-54.69%)	⬇️
lib/sequelize.js	92.83% <0%> (-3.12%)	⬇️
lib/dialects/mysql/query-generator.js	96.47% <0%> (-1.33%)	⬇️
lib/dialects/abstract/query.js	91.44% <0%> (-0.33%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218f8cd...3b8593d. Read the comment docs.

[vanthome]

From my perspective this is complete now, please merge it.

[papb]

@vanthome I see you did not add any test... Please add at least one simple test that wouldn't pass before your PR and passes after your PR. Thanks.

[vanthome]

Added a test. For whatever reason now the tests fail although they run locally!?

[vanthome]

Seems like MySQL tests fail due to some code that I integrated through rebasing. So will you merge this?

[papb]

@vanthome The test you added is running for all dialects, and failing for every dialect which is not postgres. You have to add your test in a way that it will run only for postgres. Let me know if you need further help.

[papb]

@vanthome Just add your test here instead and it should work.

[vanthome]

Strange because previously the tests passed I think. Anyways, I have moved it there.

[vanthome]

Now the PG native test seems to fail which has nothing to do with my change. What to do now?

[papb]

@vanthome Nothing else to do! That error in postgres-native is an intermittent error that has been happening in Sequelize for a while... We can all ignore it.

Thank you very much for the PR! Looks ready to merge.

Let's wait for @sushantdhiman

[vanthome]

Great, looking forward.

[papb]

@vanthome There are conflicts with master, can you please resolve them?

[vanthome]

Oh crap, I just pushed another update to my local branch, I did not want to add this to this PR. Do you know how I can revert this?

[papb]

@vanthome Ah, that explains the last commit 😬

You can just revert the commit normally (git revert), don't worry about the "ugly git history" because everything will be squashed on merge anyway.

[vanthome]

I have undone the malicious change. When will this be merged now?

[papb]

Hi! There are still conflicts...

[vanthome]

Well this was w/o conflicts. why has it not been merged then?
I mean why should I put more effort into this, is it does not get merged anyway?

[papb]

Well this was w/o conflicts.

Indeed! But as time passes, conflicts may appear, it's normal.

why has it not been merged then?

Because maintainers are busy

I mean why should I put more effort into this, is it does not get merged anyway?

You don't have to do anything. In open source no one is forced to anything... I, like you, would like to see every PR merged as well.

[papb]

I fixed the conflict for you 👍

[vanthome]

Great, looking forward for a merge.

[sushantdhiman]

🎉 This PR is included in version 5.18.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀