Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(transaction): fix typo #11659

merged 1 commit into from Nov 9, 2019

docs(transaction): fix typo #11659

merged 1 commit into from Nov 9, 2019


Copy link

@aGolduck aGolduck commented Nov 7, 2019

Subsections of "Concurrent/Partial transactions" in
should be "WITH CLS enabled" instead of "WITHOUT CLS enabled".
See comment in the code below section header

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Subsections of "Concurrent/Partial transactions" in 
should be "WITH CLS enabled" instead of "WITHOUT CLS enabled".
See comment in the code below section header
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #11659 into master will increase coverage by 3.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11659      +/-   ##
+ Coverage   92.47%   96.24%   +3.77%     
  Files          91       94       +3     
  Lines        8903     9190     +287     
+ Hits         8233     8845     +612     
+ Misses        670      345     -325
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 94.36% <0%> (-1.41%) ⬇️
lib/dialects/sqlite/index.js 100% <0%> (ø)
lib/dialects/sqlite/query.js 98.65% <0%> (ø)
lib/dialects/sqlite/connection-manager.js 100% <0%> (ø)
lib/data-types.js 91.34% <0%> (+0.34%) ⬆️
lib/dialects/abstract/query-generator.js 97.01% <0%> (+0.51%) ⬆️
lib/dialects/abstract/query.js 91.98% <0%> (+0.96%) ⬆️
lib/sequelize.js 95.93% <0%> (+1.25%) ⬆️
lib/transaction.js 100% <0%> (+2.66%) ⬆️
lib/query-interface.js 92.19% <0%> (+3.41%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbef15f...570ed48. Read the comment docs.

@aGolduck aGolduck changed the title docs: fix typo docs(transaction): fix typo Nov 8, 2019
Copy link

papb commented Nov 9, 2019

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

@papb papb merged commit 71d124c into sequelize:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants