Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pool): Expose the recently added maxUses pool config option #12101

Merged
merged 2 commits into from Apr 14, 2020

Conversation

chriskchew
Copy link
Contributor

@chriskchew chriskchew commented Apr 13, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Expose the recently added maxUses pool config option (sequelize/sequelize-pool#18).

I followed the instructions given in #12057, with the additional step of updating the PoolOptions type definition.

Thank you for all your help!

@codecov
Copy link

@codecov codecov bot commented Apr 13, 2020

Codecov Report

Merging #12101 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12101   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          95       95           
  Lines        9244     9244           
=======================================
  Hits         8889     8889           
  Misses        355      355           
Impacted Files Coverage Δ
lib/dialects/abstract/connection-manager.js 90.67% <ø> (ø)
lib/sequelize.js 95.97% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a283dc0...adc2bf6. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 5d51e69 into sequelize:master Apr 14, 2020
4 checks passed
@papb
Copy link
Member

@papb papb commented Apr 19, 2020

Thank you very much @chriskchew!

lacarnesecca pushed a commit to macmillanhighered/sequelize that referenced this issue May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants