feat(pool): Expose the recently added maxUses pool config option#12101
Merged
sushantdhiman merged 2 commits intosequelize:masterfrom Apr 14, 2020
Merged
feat(pool): Expose the recently added maxUses pool config option#12101sushantdhiman merged 2 commits intosequelize:masterfrom
sushantdhiman merged 2 commits intosequelize:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12101 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 95 95
Lines 9244 9244
=======================================
Hits 8889 8889
Misses 355 355
Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Apr 14, 2020
Member
|
Thank you very much @chriskchew! |
lacarnesecca
pushed a commit
to macmillanhighered/sequelize
that referenced
this pull request
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Expose the recently added
maxUsespool config option (sequelize/sequelize-pool#18).I followed the instructions given in #12057, with the additional step of updating the
PoolOptionstype definition.Thank you for all your help!