Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: asyncify #12297

Merged
merged 1 commit into from May 23, 2020
Merged

docs: asyncify #12297

merged 1 commit into from May 23, 2020

Conversation

SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented May 22, 2020

#9552 # Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Update js docs and ts to use async await.
Improved describeTable typings while at it.

@SimonSchick SimonSchick requested a review from sushantdhiman May 22, 2020
@codecov
Copy link

@codecov codecov bot commented May 22, 2020

Codecov Report

Merging #12297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12297   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          95       95           
  Lines        9125     9125           
=======================================
  Hits         8793     8793           
  Misses        332      332           
Impacted Files Coverage Δ
lib/associations/belongs-to-many.js 98.02% <ø> (ø)
lib/model.js 96.63% <ø> (ø)
lib/sequelize.js 95.81% <ø> (ø)
lib/transaction.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31d68d...26bbb2f. Read the comment docs.

lib/sequelize.js Outdated Show resolved Hide resolved
lib/sequelize.js Outdated Show resolved Hide resolved
lib/sequelize.js Outdated Show resolved Hide resolved
lib/sequelize.js Outdated Show resolved Hide resolved
lib/transaction.js Outdated Show resolved Hide resolved
types/lib/model.d.ts Outdated Show resolved Hide resolved
types/lib/model.d.ts Outdated Show resolved Hide resolved
types/lib/model.d.ts Outdated Show resolved Hide resolved
types/lib/sequelize.d.ts Outdated Show resolved Hide resolved
types/lib/sequelize.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

LGTM apart from changes suggested by @papb

papb
papb approved these changes May 23, 2020
@sushantdhiman sushantdhiman merged commit 8244a34 into master May 23, 2020
1 of 2 checks passed
@sushantdhiman sushantdhiman deleted the chore/asyncify-docs branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants