-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: asyncify #12297
docs: asyncify #12297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12297 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 95 95
Lines 9125 9125
=======================================
Hits 8793 8793
Misses 332 332
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from changes suggested by @papb
0a57c7d
to
26bbb2f
Compare
#9552 # Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Update js docs and ts to use async await.
Improved
describeTable
typings while at it.