docs: asyncify#12297
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12297 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 95 95
Lines 9125 9125
=======================================
Hits 8793 8793
Misses 332 332
Continue to review full report at Codecov.
|
papb
requested changes
May 23, 2020
sushantdhiman
approved these changes
May 23, 2020
Contributor
sushantdhiman
left a comment
There was a problem hiding this comment.
LGTM apart from changes suggested by @papb
0a57c7d to
26bbb2f
Compare
papb
approved these changes
May 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9552 # Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Update js docs and ts to use async await.
Improved
describeTabletypings while at it.